add defined type postgresql::server::reassign_owned_by #894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hunner
approved these changes
Jul 6, 2017
|
|
||
| if($db != undef and defined(Postgresql::Server::Database[$db])) { | ||
| Postgresql::Server::Database[$db]->Postgresql_psql["reassign_owned_by:${db}:${sql_command}"] | ||
| } |
There was a problem hiding this comment.
Just for future reference, due to parse ordering, if the Postgresql::Server::Database or role is not yet parsed at the time that this code runs, then it will not be defined() and this will not add the dependency even though the database/role will be declared later in the compile. To avoid this, we use collectors for conditional dependencies:
Postgresql::Server::Role <| title == $old_role |> -> Postgresql_psql["reassign_owned_by:${db}:${sql_command}"]
Postgresql::Server::Role <| title == $new_role |> -> Postgresql_psql["reassign_owned_by:${db}:${sql_command}"]
Postgresql::Server::Database <| title == $db |> -> Postgresql_psql["reassign_owned_by:${db}:${sql_command}"]
hunner
added a commit
that referenced
this pull request
Jul 6, 2017
add defined type postgresql::server::reassign_owned_by
cegeka-jenkins
pushed a commit
to cegeka/puppet-postgresql
that referenced
this pull request
Feb 3, 2022
add defined type postgresql::server::reassign_owned_by
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new defined type postgresql::server::reassign_owned_by which runs the SQL:
REASSIGN OWNED BY "old_role" TO "new_role"on a given database.